datasets / s-and-p-500-companies

List of companies in the S&P 500 together with associated financials
https://datahub.io/core/s-and-p-500-companies
499 stars 491 forks source link

Wikipedia #11

Closed lexman closed 8 years ago

lexman commented 8 years ago

Hello,

I changed the source of the data to wikipedia, according to https://github.com/datasets/s-and-p-500-companies/issues/8. I used tuttle as a glue to the new scripts.

As discussed, I kept it simple and included a Makefile.

Hopefully, we'll be able to close many of the open issues relating to this dataset with this PR :)

Lexman

lexman commented 8 years ago

@rgrp I made the changes you suggested :)

I'm quite proud of the Makefile : it is a huge improvement from the python scripts. I've completely removed tuttle from the process for the sake of simplicity and because it is redundant with Make.

I'll try to convience you with a post in the lab to make another huge improvement to this process : switch to tuttle wich is an enhanced version of Make, .

I'm leaving you do the merge so you can check if it suits you

rufuspollock commented 8 years ago

@lexman this is great and really want to talk about tuttle as it looks really interesting (and you also clearly know what you are doing here :-) ...)

lexman commented 8 years ago

@rgrp, as promised, why tuttle is even better than make : https://discuss.okfn.org/t/tools-for-datapackages-make-vs-tuttle/2262... Happy reading !