search

datasets / s-and-p-500-companies

List of companies in the S&P 500 together with associated financials
https://datahub.io/core/s-and-p-500-companies
499 stars 491 forks source link

Remove constituents-financials? #19

Closed noahg closed 6 years ago

noahg commented 6 years ago

Hello, cool project. I propose that the constituent-financials be removed from this data package.

The constituents.csv table is useful in its own right, containing symbol, name, and sector. This file currently still builds but the overall makefile is failing for multiple reasons, one of which is that the Yahoo Finance API seems to have have changed its terms or perhaps is going away altogether. which is causing the constituents-financials to fail.

My assumption is that stock quote and other financial data will forever be relegated to depending on free services that should be considered at a minimum as less dependable than the Wikipedia dependence for just the constituents data.

The financials are useful but they could be appended by a separate data package that validates the financials only.

rufuspollock commented 6 years ago

@noahg very good point. My preference here would be to fork this dataset to have a new dataset s-and-p-companies-financials that contains this historical information and which we try to support going forward and this becomes just the list of companies.

wdyt? Input from users is always very welcome!

PS: if you're interested in helping maintain datasets like this you can become part of our core data curator team http://datahub.io/docs/core-data/curators

noahg commented 6 years ago

Yes, that makes sense to me. I can keep going on this repo under a new branch, to remove the financials portion. Are you able to fork this and create the s-and-p-companies-financials repo? I can pick up with that one after finishing this.

rufuspollock commented 6 years ago

@Mikanebu can you create a new repo under datasets named s-and-p-companies-financials and then clone this repo and repush it to there (that will be the equivalent of forking for our purposes here).

Mikanebu commented 6 years ago

@rufuspollock @noahg created new repo https://github.com/datasets/s-and-p-companies-financials

rufuspollock commented 6 years ago

@noahg are you still up for doing the change here and we keep financials in the separate repo?

noahg commented 6 years ago

Yes I am. Sorry for the delay. Got halfway there today. Will hopefully finish up tomorrow. Planning to use "IEX Trading" for the new financials repo. https://iextrading.com/developer/

noahg commented 6 years ago

Okay, I submitted a PR to https://github.com/datasets/s-and-p-companies-financials which uses the IEX API. I'm working backwards from the end-point I suppose. Take a look at that and let me know what you think. Then I can get to working on fixing up this one but I want to make sure my approach is what you're looking for. Thanks!

Mikanebu commented 6 years ago

@noahg Great! Thanks for your contribution!