search

datasets / un-locode

United Nations Codes for Trade and Transport Locations (UN/LOCODE) and Country Codes
https://datahub.io/core/un-locode
146 stars 56 forks source link

Lastest update #10

Closed Corendiel closed 8 years ago

Corendiel commented 8 years ago

Hello,

I interested to use your service but I'm wondering if you are using the last UN update ? I don't see on your page when is the last time your list has been updated. Your total number of code is 102690 while on the unece website they say they have over 103034 locations.

Thanks

rufuspollock commented 8 years ago

@sabas do you have any comment here given your latest pull request :-)

I think we are at the latest data.

sabas commented 8 years ago

@Corendiel it's the 2015-2 version. I convert the access database to get the data in this repository... I wonder where it comes the 334 difference. Perhaps they count also the "headers" into the file? (I remove the rows like IT, Italy and so on from the codelist)

sabas commented 8 years ago

Yup the difference is that. I did a quick count in Rstudio image

Example of removed rows image

Since I don't consider them proper locodes I chose to remove them

Corendiel commented 8 years ago

Ok thanks for you response. Just as a suggestion, on the Okfn.org page there is no mention to the version, I realize I could have check your comments in the Code on Git but maybe you could update the Reade me for visitors who don't know Git. Thanks again

sabas commented 8 years ago

@rgrp is there an issue on data.okfn.org repo for this?

rufuspollock commented 8 years ago

@sabas no - can you open one.

sabas commented 8 years ago

Done. This issue can be closed I think

rufuspollock commented 8 years ago

FIXED. Thanks all.