[fix][xl] Fixing the workflow in the dataset

[gradedSystem]

Changes made

• Fixed down the workflow of getting the files from unlocode website
• adjusted the scripts
• added new data
• fixed bash script
• added Makefile

cc @anuveyatsu @sabas

[gradedSystem]

hi @sabas can you confirm this looks fine?

[sabas]

Thanks, questions:

• are the quotation marks necessary for all the fields in the output? (if I remember I used csvclean to remove them)
• csvkit and mdbtools are prerequisites for the bash script I wonder if you need to tell this somewhere to allow for automation
• subdivision codes don't work, as it's missing the SUType column

[gradedSystem]

Thank you for reviewing @sabas :

1. Yes i can remove the quotation marks
2. As for the automation it could be done in .github/workflows I will adjust this PR to the latest changes #31
3. I will fix the script and add subdivision codes

[gradedSystem]

@sabas With my latest script I handled the case that you mentioned

1. Quotation marks removed from .csv files
2. I will update the script #31 and automate updating the mdbtools and others
3. Subdivision codes now should have SUType column

[sabas]

@gradedSystem please fix the latest outstanding issue in subdivision file and it'd be good to merge Build failed currently as requirements.txt is in this PR

[gradedSystem]

@sabas Fixed down the code with the latest oustanding issue #32

[sabas]

I don't get it, I asked to change subdivision NA issue..

[gradedSystem]

Hi @sabas, I thought that when you said latest oustanding issue it was one that was mentioned here: #32 If I understood you correctly you are saying to fix the issues when SUCode has a missing value?

[sabas]

@gradedSystem see the notes I added in subdivision-codes, the script omits NA in the fields, and the name has spaces that can be trimmed

[gradedSystem]

@sabas should I keep the function which addresses latest oustanding issue? this one #32 that converts coordinates.

btw I fixed down the subdivision NA issue just waiting your response for above question.

[gradedSystem]

@sabas fixed the issue

[sabas]

@sabas should I keep the function which addresses latest oustanding issue? this one #32 that converts coordinates.

btw I fixed down the subdivision NA issue just waiting your response for above question.

Sorry, I got it now, No please keep them as in the original dataset, conversion shall be done downstream

[gradedSystem]

@sabas Ok got it i will remove the function for conversion and I think it is good to go

[gradedSystem]

@sabas should be fixed now