datasets / un-locode

United Nations Codes for Trade and Transport Locations (UN/LOCODE) and Country Codes
https://datahub.io/core/un-locode
146 stars 56 forks source link

No country code for Namibia #39

Open dwaam opened 2 days ago

dwaam commented 2 days ago

Hi,

It seems to have another issue with the code list, UNLOCODES from NAMIBIA have no COUNTRY CODE.

,,AIW,Ai-Ais,Ai-Ais,,AI,---4----,0001,,,
,,ADI,Arandis,Arandis,,AI,---4----,0001,,,
,,VFG,Ariamsvlei,Ariamsvlei,KA,RL,--3-----,1601,,2807S 01949E,
,,ZAR,Aussenkehr,Aussenkehr,,RL,-----6--,0901,,2821S 01723E,
,,BQI,Bagani,Bagani,,AI,---4----,0001,,,
,,GOG,Gobabis,Gobabis,,AI,---4----,0001,,,
,,GFY,Grootfontein,Grootfontein,,AI,---4----,9601,,,
,,HAL,Halali,Halali,,AI,---4----,0001,,,
,,HTN,Henties Bay (Hentiesbaai),Henties Bay (Hentiesbaai),ER,RL,--3-----,1501,,2207S 01417E,
,,KAS,Karasburg,Karasburg,,AI,---45---,9805,,,
,,KRB,Karibib,Karibib,,RL,--3-----,0201,,2156S 01551E,
,,KAT,Katima Mulilo,Katima Mulilo,CA,RL,--3-----,1707,,1730S 02416E,
,,KMP,Keetmanshoop,Keetmanshoop,,AI,---4----,9601,,,
,,LUD,Lüderitz,Luderitz,,AI,1--4----,0212,,2639S 01510E,
,,MTH,Maltahohe,Maltahohe,HA,RQ,-----6--,1001,,2450S 01659E,
,,MAR,Mariental,Mariental,,AI,----5---,9805,,,
,,MQG,Midgard,Midgard,,AI,---4----,0001,,,
,,OKU,Mokuti Lodge,Mokuti Lodge,,AI,---4----,0001,,,
,,MJO,Mount Etjo Lodge,Mount Etjo Lodge,,AI,---4----,0001,,,
,,MPA,Mpacha,Mpacha,,AI,---4----,0001,,,
,,NNI,Namutoni,Namutoni,,AI,---4----,0001,,,
,,WOR,Noordoewer,Noordoewer,KA,AI,--3-5---,0307,,2845S 01737E,
,,OOZ,Okahandja,Okahandja,OD,RL,-----6--,1401,,2159S 01655E,
,,OKF,Okaukuejo,Okaukuejo,,AI,---4----,0001,,,
,,OMA,Omaruru,Omaruru,ER,RL,--3-----,0901,,2126S 01556E,
,,OMG,Omega,Omega,,AI,---4----,0001,,,
,,OND,Ondangwa,Ondangwa,,AI,---4----,0001,,,
,,OGV,Ongava Game Reserve,Ongava Game Reserve,,AI,---4----,0001,,,
,,ONG,Ongwediva,Ongwediva,ON,RL,--3-----,1901,,1746S 01545E,
,,OPW,Opuwa,Opuwa,,AI,---4----,0001,,,
,,OMD,Oranjemund,Oranjemund,,RQ,---4----,9012,,,
,,OHI,Oshakati,Oshakati,,AI,---45---,9805,,,
,,OSH,Oshikango,Oshikango,OW,RL,-----6--,1407,,1724S 01553E,
,,OVO,Oshivelo,Oshivelo,OT,RL,--3-----,1707,,1837S 01710E,
,,OTP,Otavi,Otavi,OD,RL,--3-----,1601,,1939S 01720E,
,,OTJ,Otjiwarongo,Otjiwarongo,,AI,---45---,9805,,,
,,OUT,Outjo,Outjo,KU,RL,--3-----,1901,,2007S 01609E,
,,RUA,Ruacana,Ruacana,KU,RQ,1----6--,1001,,1726S 01421E,
,,NDU,Rundu,Rundu,,AI,---4----,0001,,,
,,SZM,Sesriem,Sesriem,,AI,---4----,0001,,,
,,SWP,Swakopmund,Swakopmund,,AI,---45---,9805,,,
,,TCY,Terrace Bay,Terrace Bay,,AI,---4----,0001,,,
,,TSB,Tsumeb,Tsumeb,,AI,---4----,9601,,,
,,UIS,Uis,Uis,ER,RL,--3-----,1801,,2113S 01451E,
,,WVB,Walvis Bay,Walvis Bay,,QQ,1-------,8103,,,
,,WDH,Windhoek,Windhoek,,AI,---45---,9601,,,
,,ERS,Windhoek Eros Airport,Windhoek Eros Airport,KH,RL,---4----,1607,,2236S 01704E,

Is it possible to fill them @gradedSystem ?

Thanks by advance

sabas commented 2 days ago

It's the same NA issue in the python script..

gradedSystem commented 2 days ago

@sabas can you point out which issue it was?

dwaam commented 2 days ago

It seems to be related to this commit, if I guess correctly: https://github.com/datasets/un-locode/commit/3b53333ef82cf4a358287f1bbdea58d4ab09b3e5

but with the code-list file this time.

gradedSystem commented 14 hours ago

@dwaam can you confirm if the missing values are fixed with latest PR cc @sabas

dwaam commented 9 hours ago

For Namibia, yes.

But I've just found some remaining issues with 5 lines now:

,NO,LID,Liland,Liland,18,1-------,,1501,,6820N 01445E, ,GB,UBL,Upper Ballinderry,Upper Ballinderry,ANN,--3-----,,1701,,5432N 00612W, ,MY,PJK,Pulau Jarak,Pulau Jarak,,1-------,,1307,,0358N 10005E, +,PY,FDM,Fernando De La Mora,Fernando De La Mora,11,--3-----,,2307,,2519S 05734W, ,NO,HEV,Helligvær,Helligvar,18,1-------,,1501,,6724N 01332E,

For those 5, the function is still not at the right place :s

dwaam commented 9 hours ago
┌─────────┬─────────┬──────────┬─────────────────────┬─────────────────────┬─────────────┬──────────┬──────────┬─────────┬─────────┬──────────────┬─────────┐
│ Change  │ Country │ Location │        Name         │  NameWoDiacritics   │ Subdivision │  Status  │ Function │  Date   │  IATA   │ Coordinates  │ Remarks │
│ varchar │ varchar │ varchar  │       varchar       │       varchar       │   varchar   │ varchar  │ varchar  │ varchar │ varchar │   varchar    │ varchar │
├─────────┼─────────┼──────────┼─────────────────────┼─────────────────────┼─────────────┼──────────┼──────────┼─────────┼─────────┼──────────────┼─────────┤
│         │ GB      │ UBL      │ Upper Ballinderry   │ Upper Ballinderry   │ ANN         │ --3----- │          │ 1701    │         │ 5432N 00612W │         │
│         │ MY      │ PJK      │ Pulau Jarak         │ Pulau Jarak         │             │ 1------- │          │ 1307    │         │ 0358N 10005E │         │
│         │ NO      │ HEV      │ Helligvær           │ Helligvar           │ 18          │ 1------- │          │ 1501    │         │ 6724N 01332E │         │
│         │ NO      │ LID      │ Liland              │ Liland              │ 18          │ 1------- │          │ 1501    │         │ 6820N 01445E │         │
│ +       │ PY      │ FDM      │ Fernando De La Mora │ Fernando De La Mora │ 11          │ --3----- │          │ 2307    │         │ 2519S 05734W │         │
└─────────┴─────────┴──────────┴─────────────────────┴─────────────────────┴─────────────┴──────────┴──────────┴─────────┴─────────┴──────────────┴─────────┘