search

datasharingframework / dsf

A distributed process engine based on the BPMN 2.0 and FHIR R4 standards
https://dsf.dev
Apache License 2.0
12 stars 7 forks source link

Don't require DEV_DSF_FHIR_SERVER_ORGANIZATION_THUMBPRINT #177

Open schwzr opened 9 months ago

schwzr commented 9 months ago

In theory, the value DEV_DSF_FHIR_SERVER_ORGANIZATION_THUMBPRINT should not be required as we are already required to set the client certificate on the fhir server.

Theoretically, it would therefore be possible to omit the value in most cases, so that this easily missed step is no longer necessary when updating a client certificate.

For "more special constructs", e.g. if a different client certificate is used on the FHIR server than on the BPE server, the bundle.xml file would probably have to be adapted manually anyway.

hhund commented 5 months ago

Could be implemented similar to the injectEndpointProperties function of the PropertiesConfig class:

https://github.com/datasharingframework/dsf/blob/8bb557430406a46c971488356a0c88fe5eed2712/dsf-fhir/dsf-fhir-server/src/main/java/dev/dsf/fhir/spring/config/PropertiesConfig.java#L156-L174