Local settings .

[patRyserWelch8]

Hi Olly,

This is the implementation of what we discussed last week. It would be great if the .ignore file could ignore this file: testthat/connection_to_datasets/local_settings.csv

Cheers,

P.

[OllyButters]

Hi @patRyserWelch8 - this has failed the CI tests so I am not merging it yet. @StuartWheater - my assumption is that this is going to be related to password differences between the local and CI builds, would you agree?

[patRyserWelch8]

Hi,

Thank you. We will sort it tomorrow or next week. This change was going to be a bit tricky.

Good evening.

P.

Dr Patricia Ryser-Welch

Start by doing what's necessary; then do what's possible; and suddenly you are doing the impossible.

Francis of Assisi

Mankind remains the most extraordinary computer of all....

John F. Kennedy

---

From: Olly Butters notifications@github.com Sent: 23 May 2019 19:50 To: datashield/dsBetaTestClient Cc: P.Ryser-Welch; Mention Subject: Re: [datashield/dsBetaTestClient] Local settings . (#51)

Hi @patRyserWelch8https://github.com/patRyserWelch8 - this has failed the CI tests so I am not merging it yet. @StuartWheaterhttps://github.com/StuartWheater - my assumption is that this is going to be related to password differences between the local and CI builds, would you agree?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/datashield/dsBetaTestClient/pull/51?email_source=notifications&email_token=AK2RRPUYNVVV52GSGUL7Q3DPW3ROZA5CNFSM4HPIZCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDEWCA#issuecomment-495340296, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK2RRPUJAOCL36ZMOIMYBXDPW3ROZANCNFSM4HPIZCDA.

[StuartWheater]

Olly, I assume this allows local setting of password, username, URL, ...

Patricia, Have you looked at the file ".gitignore" in the packages root directory?

Stuart Dr Stuart Wheater Postal Address: Arjuna Technologies Limited, Urban Sciences Building, 1 Science Square, Bath Lane, Newcastle upon Tyne, NE4 5TG United Kingdom VAT Registration No: 764173128. Company registered in England Registration No: 4497081

On Thu, 23 May 2019 at 20:01, Patricia Ryser-Welch notifications@github.com wrote:

Hi,

Thank you. We will sort it tomorrow or next week. This change was going to be a bit tricky.

Good evening.

P.

Dr Patricia Ryser-Welch

Start by doing what's necessary; then do what's possible; and suddenly you are doing the impossible.

Francis of Assisi

Mankind remains the most extraordinary computer of all....

John F. Kennedy

---

From: Olly Butters notifications@github.com Sent: 23 May 2019 19:50 To: datashield/dsBetaTestClient Cc: P.Ryser-Welch; Mention Subject: Re: [datashield/dsBetaTestClient] Local settings . (#51)

Hi @patRyserWelch8https://github.com/patRyserWelch8 - this has failed the CI tests so I am not merging it yet. @StuartWheater< https://github.com/StuartWheater> - my assumption is that this is going to be related to password differences between the local and CI builds, would you agree?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://github.com/datashield/dsBetaTestClient/pull/51?email_source=notifications&email_token=AK2RRPUYNVVV52GSGUL7Q3DPW3ROZA5CNFSM4HPIZCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDEWCA#issuecomment-495340296>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AK2RRPUJAOCL36ZMOIMYBXDPW3ROZANCNFSM4HPIZCDA

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datashield/dsBetaTestClient/pull/51?email_source=notifications&email_token=AA64GWBUCEUBPD7ZGL4VZTLPW3SZBA5CNFSM4HPIZCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDFVZI#issuecomment-495344357, or mute the thread https://github.com/notifications/unsubscribe-auth/AA64GWGZAQK7PRFWHDTIQDTPW3SZBANCNFSM4HPIZCDA .