datasig-ac-uk / esig

esig python package
https://esig.readthedocs.io/en/latest/
GNU General Public License v3.0
42 stars 3 forks source link

Recombine returns null without setting error #118

Closed inakleinbottle closed 2 years ago

inakleinbottle commented 3 years ago

Recombine returns nullptr to the Python layer without calling PyErr_SetString to cause an exception to be set in the Python environment. This causes a hard error in Python.

To fix this, we need to add a call to PyErr_SetString before returning nullptr.