datasnakes / OrthoEvolution

An easy to use and comprehensive python package which aids in the analysis and visualization of orthologous genes. 🐵
https://orthoevolution.readthedocs.io/en/master/
29 stars 4 forks source link

Speeding up BLAST (Phasing out GI numbers) #113

Closed grabear closed 6 years ago

grabear commented 6 years ago

So in order to keep our code-base up to date, we need to drop the GI list functionality. link

I think it would be best for long term development if we do this. It would simply require changing the following:

So instead of creating GI list we are creating Accession.Version lists.

To my understanding this should be a relatively seamless transition. Alternatively we can also create a masked database, but I know you have more experience with that than I do @sdhutchins

sdhutchins commented 6 years ago

@grabear Completely agree here with this. I'm going to take it down to Medium Priority because it's important but not hindering the completeness of the package working (gi vs accession). I'll address that as I continue to rework the gi_list_config function and keep you updated on where I get with that.

sdhutchins commented 6 years ago

Will work to phase in https://www.ncbi.nlm.nih.gov/books/NBK279668/#_usermanual_BLASTWindowMasker_integration_

grabear commented 6 years ago

115 has been issued to document deprecation of GI numbers.

sdhutchins commented 6 years ago

120