datasnakes / OrthoEvolution

An easy to use and comprehensive python package which aids in the analysis and visualization of orthologous genes. 🐵

https://orthoevolution.readthedocs.io/en/master/

29 stars 4 forks source link

Add Tools/PBS module, a rework of the Tools/SGE module. #152

Closed grabear closed 5 years ago

grabear commented 5 years ago

Overview of Changes

Removed:

Tools/mpi module
Most of Tools/sge, excluding sgepipelinetask.py

Added:

Tools/pbs module
- Added qstat.py
- Ported from qwatch
- Added qsub.py
- Ported from sge

grabear commented 5 years ago

@sdhutchins I've fixed the merge conflicts and this is now ready for review.

grabear commented 5 years ago

This is looking quite good. Very well thought out and put together.

I made a few suggestions. Also, could we integrate a little bit more logging into these 2 main classes?

Thanks! Honestly, I meant to do the logging more. Thanks for catching that!

grabear commented 5 years ago

Alright, @sdhutchins What's left is that I need to commit some logging into this branch. I will do that tomorrow.

grabear commented 5 years ago

@sdhutchins I added some logging. Let me know if that's sufficient and in the right places.