datasnakes / OrthoEvolution

An easy to use and comprehensive python package which aids in the analysis and visualization of orthologous genes. 🐵
https://orthoevolution.readthedocs.io/en/master/
29 stars 4 forks source link

Major updates to database management, ftp, pbs, etc. #155

Closed grabear closed 4 years ago

grabear commented 5 years ago

Fixes issues #134, #95

sdhutchins commented 5 years ago

OMG, 550 commits lol

sdhutchins commented 4 years ago

wait

grabear commented 4 years ago

I have done my best @sdhutchins!

sdhutchins commented 4 years ago

I have done my best @sdhutchins!

I just had to tease you! lol There's a lot here...

sdhutchins commented 4 years ago

@grabear something is suddenly broken with the blast stuff? Any ideas?

sdhutchins commented 4 years ago

Something changed with the taxonomy on NCBI's end that's causing the blast test to fail.

grabear commented 4 years ago

It might be ete3 as well. That's always weird. I'm going to check this out after lunch. Can't do much right now.

sdhutchins commented 4 years ago

It might be ete3 as well. That's always weird. I'm going to check this out after lunch. Can't do much right now.

No worries! Seems like something small.

sdhutchins commented 4 years ago

It might be ete3 as well. That's always weird. I'm going to check this out after lunch. Can't do much right now.

Seems someone else had the same issue as well. https://github.com/etetoolkit/ete/issues/469

I'll try a work around that just "kills" the blast to make the test pass.

sdhutchins commented 4 years ago

@grabear im going to add back code coverage this afternoon, and I think I we'll be good to go since that text failure isn't based on us.

sdhutchins commented 4 years ago

Once you review #167, we can go on and merge this!

I'm so happyyyyy! haha

nbc-agt-americas-got-talent-3ov9jILUtdI1HbiR8Y

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@64593b1). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage          ?   15.13%           
=========================================
  Files             ?       67           
  Lines             ?     4182           
  Branches          ?        0           
=========================================
  Hits              ?      633           
  Misses            ?     3549           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64593b1...1c1bf90. Read the comment docs.

grabear commented 4 years ago