datasnakes / renv

Creating virtual environments for R.
MIT License
17 stars 0 forks source link

Update master with dev-master. #37

Closed grabear closed 5 years ago

grabear commented 5 years ago
santina commented 5 years ago

GitHub's review system is broken. I cannot do inline comment. But in general here are my first round feedback:

santina commented 5 years ago

I cannot do any inline comments for some reason... Those are my first round feedback.

On Fri, Oct 19, 2018 at 2:37 PM Rob Gilmore notifications@github.com wrote:

Assigned #37 https://github.com/datasnakes/renv/pull/37 to @santina https://github.com/santina.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/datasnakes/renv/pull/37#event-1915791007, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_d32IsGTA7HcImA9dAnHDjeQX2SXY1ks5umkYvgaJpZM4XxdfI .

grabear commented 5 years ago

Closing this and creating another PR. Something is wrong with the old suggestions. I cant commit directly and it's a bit confusing.

grabear commented 5 years ago

This is super weird. We must have made commits without properly fixing merge conflicts.