search

datasnakes / renv

Creating virtual environments for R.
MIT License
17 stars 0 forks source link

Code cleanup #42

Closed grabear closed 5 years ago

sdhutchins commented 5 years ago

It looks clean to me.

santina commented 5 years ago

Please be sure to test the code and it'd be all good! :)

grabear commented 5 years ago

😆 I will this afternoon.

grabear commented 5 years ago

@santina I've gotten this to work on my system, and I cleaned up the appropriate code. There are still some things that need to be done, but they can be resolved in another major PR.

sdhutchins commented 5 years ago

Once this gets merged, I'll submit a PR for the debug logging that should be helpful for rebuilding the code base.

grabear commented 5 years ago

Please reply to the comments given. You don't need to address everything, but just need to give a reason if you decide not to take the suggestion.

Thank you for the awesome review @santina. You caught some serious bugs that I overlooked. In the next PR, the code will be much easier to follow too! Let me know what you think!

grabear commented 5 years ago

I overrode the branch protection settings in order to push this through. Let me know if you have any questions.

santina commented 5 years ago

Sorry for not responding earlier. (go back in time and approve the change)