search

datasone / setup_var.efi

UEFI command-line tool for read/write access of variables
Apache License 2.0
221 stars 8 forks source link

[BUG] `--write_on_demand` #8

Closed dreamwhite closed 1 year ago

dreamwhite commented 1 year ago

Good evening and thank you so much for taking care of issue #7. I can confirm that the bug got solved with the newest release. About the newest release, I noticed that there's a new argument (--write_on_demand) which aims to avoid useless writes on the offset unless it has a different value.

In theory this is a good practice, but in the real-life tests, it seems that this argument is simply ignored, as I read Written offset blablabla. Is this just a matter of a wrong print statement, or the argument isn't properly parsed?

From my very low RUST knowledge, the argument is properly parsed (source).

datasone commented 1 year ago

Oh... I forgot to change the prompt text, the logic should have been working correctly in 0.2.0. Patch for this has been added in 0.2.1.

dreamwhite commented 1 year ago

Thank you so much! I'm going to test it this afternoon and report you back, despite from the source code the prompt text is correctly displayed, just to double check it