Got some new functionality and bugfixes in my fork, interested?

datasonnet / datasonnet-intellij-plugin

1 stars 2 forks source link

Got some new functionality and bugfixes in my fork, interested? #21

Open jhoeflaken opened 1 month ago

jhoeflaken commented 1 month ago

@fugu13 @javaduke I have some bugfixes and new functionality in my own fork of your great plugin. Are you interested in having pull requests for this or not? Otherwise I just keep on improving the plugin in my own fork only.

Bug fixes

DataSonnet libraries listed in pom.xml not loaded on Windows machines.
CRLF errors in editor (mostly on Windows).

New features

Can now set auto-refresh on or off in plugin settings.
Can now define default template in plugin settings.

javaduke commented 1 month ago

I like the default templates idea and bug fixes, but having auto refresh control in both places can be very confusing, I'd rather have it in the editor rather than global setting. Please feel free to create PRs, especially for the bug fixes.

jhoeflaken commented 1 month ago

Hi @javaduke

I will do that. The auto-refresh is the default. Currently it is always on and we don't like that as it makes the editor slow and lagging. Other option is to control it from the editor, but then I would like it to remember that if I turn it off it stays off until I turn it on again. Within the same IntelliJ session and other sessions.

javaduke commented 1 month ago

So it is already controllable form the editor, that top icon in the preview window controls auto refresh, it is a toggle action. I guess you can just persist the state of this action somewhere.

jhoeflaken commented 5 days ago

@javaduke

Took some time. I created a new fork and applied the changes. See [#24 ]