dataspread / dataspread-web

http://dataspread.github.io
135 stars 31 forks source link

NOAH loads faster than the page suggests #268

Open nathan111100 opened 4 years ago

nathan111100 commented 4 years ago

When opening NOAH, it will take 1:30-2:00 for the page to finish loading and display the Noah sidebar. That being said, sometimes if you wait for 10 -20 seconds and refresh the page, reopen the current book and sort by the same attribute that you opened before, Noah will open up almost instantaneously. This suggests that Noah actually takes much less time to load than the page suggests. An error associated to this issue is that sometimes when you refresh the page while Noah is in the middle of loading, Noah will display a blank grid and trying to open Noah again will crash the application. Here is the console after Noah finished loading without me refreshing the page. Everything from {data: Array(3)...App.js:163} shows up right before NOAH displays its loaded sidebar

Screen Shot 2020-10-15 at 1 11 59 PM
nathan111100 commented 4 years ago

Screenshot of the performance timeline

Screen Shot 2020-10-15 at 1 31 52 PM
nathan111100 commented 4 years ago

Here is the call tree. Most of the time is spent on updating the animations which is in modal.js a preinstalled package. I'm sure that there is another function that calls modal.js, but most of the time is spent running these functions so it will be worth to look at where we call request identification frame on dataspread-ui/node_module/semantic-ui-react/dist/es/modules/modal/modal.js line 183

Screen Shot 2020-10-20 at 9 49 18 PM
nathan111100 commented 4 years ago

I believe it is mangesh who added package.json, That being said, there were modifications from shichu, yuyang and tcheng. It looks like this is an error with the package.json.

Screen Shot 2020-10-21 at 9 58 01 AM