datastax / cassandra-quarkus

An Apache Cassandra(R) extension for Quarkus
Apache License 2.0
40 stars 28 forks source link

Adds docker host to test resource #104

Closed kstrempel closed 4 years ago

kstrempel commented 4 years ago

In some CI/CD pipeline system docker is not running on localhost. To avoid these problems I would like to add the application setting: quarkus.cassandra.docker_host

kstrempel commented 4 years ago

Sad I can't see the error in you CI. Local mvn compile test is working.

adutra commented 4 years ago

Hi thanks for your contribution! The CI tests are failing because of #99, I merged #100 which fixes it. If you rebase your PR I'm pretty sure the CI tests will pass.

adutra commented 4 years ago

Hmm I also see that we are going to have a problem with localhost, on my machine it resolves to 2 ips and this is going to make the driver bark. I will amend your commit a bit and special-case localhost.

adutra commented 4 years ago

@kstrempel I committed your changes directly to master with a few fixes, see d77ee70. Many thanks for your contribution!