search

datastax / cassandra-quarkus

An Apache Cassandra(R) extension for Quarkus
Apache License 2.0
40 stars 28 forks source link

Define Assertj version #205

Closed gsmet closed 2 years ago

gsmet commented 2 years ago

Assertj version is not enforced by the Quarkus BOM anymore.

Due to some repeated binary compatibility issues, we had to remove it from the BOM.

Any chance you could release a new version with this fix before February 1st? We will need it for the 2.7 Quarkus Platform release.

gsmet commented 2 years ago

Ah, wait, no sorry, we don't need a release right now, we will need one for 2.8. But it would be nice to merge it ASAP so that we can have the Ecosystem CI green.

gsmet commented 2 years ago

Still probably a good idea to do a release soon so that we don't forget about it :).

gsmet commented 2 years ago

I think runtime/.pom.xml.swp was committed by mistake, could you please remove it?

Raaah. Will do, sorry about that.

gsmet commented 2 years ago

Done. That's what I get for doing things in batches.

adutra commented 2 years ago

Done. That's what I get for doing things in batches.

No worries at all, I love when people report issues AND provide the fix at the same time :-)

Just one general remark: wouldn't it be simpler to declare AssertJ only in the parent pom and in the quickstart pom? The parent pom could look like this:

  <properties>
    <assertj.version>3.22.0</assertj.version>
  </properties>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.assertj</groupId>
        <artifactId>assertj-core</artifactId>
        <version>${assertj.version}</version>
      </dependency>
    </dependencies>
  </dependencyManagement>

As far as I can tell, this produces the same effect as declaring AssertJ in all modules that use it..

gsmet commented 2 years ago

No. Because if we do that, it would be part of your BOM and we don't want that. Keep in mind that the BOM inherits any dependency management coming from the parents (we had some very bad surprises in Quarkus with various components bringing a ton of unrelated things with their BOM).

What we do for Quarkus projects is that we have a build-parent/pom.xml with this sort of things and the BOM is explicitly not using the build-parent.

adutra commented 2 years ago

I see. Thanks for the explanation!

gsmet commented 2 years ago

Any chance this could be merged soon? Working on getting our Ecosystem CI green.

adutra commented 2 years ago

Sure thing, sorry for the delay!

adutra commented 2 years ago

Ah, wait, no sorry, we don't need a release right now, we will need one for 2.8. But it would be nice to merge it ASAP so that we can have the Ecosystem CI green.

@gsmet what's the ETA for Quarkus 2.8? As in, when do you need us to release? :-)

gsmet commented 2 years ago

If you release one month from now, that should be OK.