search

datastax / cstar_perf

Apache Cassandra performance testing platform
Apache License 2.0
72 stars 34 forks source link

Add support for dse.yaml settings #139

Closed nastra closed 8 years ago

nastra commented 8 years ago

This PR will add support for configuring dse.yaml settings. The dse.yaml div container in the UI will also only be shown if dse is selected from the product dropdown.

aboudreault commented 8 years ago

The code looks good to me. I will give this a try locally.

aboudreault commented 8 years ago

@nastra when you got a minute, can you add me as collaborator of you cstar_perf repo? I have to push 3 minor fixes and we'll be good to merge. I've also rebased on latest master.

EnigmaCurry commented 8 years ago

If it makes it easier, for future PRs you can create a branch directly on this repo @nastra, you have access. That way we can push fixes onto the same PR. On Nov 25, 2015 4:56 PM, "Alan Boudreault" notifications@github.com wrote:

@nastra https://github.com/nastra when you got a minute, can you add me as collaborator of you cstar_perf repo? I have to push 3 minor fixes and we'll be good to merge. I've also rebased on latest master.

— Reply to this email directly or view it on GitHub https://github.com/datastax/cstar_perf/pull/139#issuecomment-159740409.

nastra commented 8 years ago

@aboudreault I don't have an own cstar_perf repo, I'm pushing directly to the datastax cstar_perf repo and the changes are on the branch ET-dseyaml-support, so you should have access to that branch

aboudreault commented 8 years ago

sorry, my bad. I added your github remote by habits and was sure the branch was there then.

aboudreault commented 8 years ago

Just pushed my minor fixes. The first one is to show dse yaml when cloning a job. Thanks for you work!!

nastra commented 8 years ago

@aboudreault thanks for the fixes