datastax / cstar_perf

Apache Cassandra performance testing platform
Apache License 2.0
72 stars 34 forks source link

Improve handling of spark-cassandra-stress dropdown value #165

Closed nastra closed 8 years ago

nastra commented 8 years ago

I improved the handling of the spark-cassandra-stress dropdown value. The initial approach of adding that value (by doing $(e).append($("<option value='spark_cassandra_stress'>spark-cassandra-stress</option>"))) in case dse is selected in the product list lead to a couple of issues, where e.g. the spark-cassandra-stress option wasn't automatically added when the job was cloned or when a new operation was added.

I created a separate function that deals with the spark-cassandra-stress dropdown value. The logic is basically as following:

The function maybe_show_spark_cassandra_stress_option() is now called in three cases:

aboudreault commented 8 years ago

LGTM!

nastra commented 8 years ago

thanks for the fast review!