search

datastax / cstar_perf

Apache Cassandra performance testing platform
Apache License 2.0
72 stars 34 forks source link

Bind RMI server to public IP instead of hostname #170

Closed nastra closed 8 years ago

nastra commented 8 years ago

Previously, it would just bind to the hostname and you couldn't establish a remote JMX connection if you don't have the proper name resolution configured. The easy fix is to always bind the RMI server to the host's public IP address.

@aboudreault / @EnigmaCurry can you guys review please?

EnigmaCurry commented 8 years ago

I would argue that if you 'don't have the proper name resolution configured' you should just be using an IP address for hostname in the cluster_config.

By calling gethostbyname you're assuming that the client is on the same network as the nodes. If that's the case, why not just use the internal_ip listed in the cluster_config? I'm more partial to using the explicit config in cluster_config than doing auto-determination of IPs.

nastra commented 8 years ago

Oh right I forgot that we actually have the IP addresses specified in cluster_config.json. I will change the logic to read the IP from that file. Thanks for the hint

nastra commented 8 years ago

@EnigmaCurry please re-review

EnigmaCurry commented 8 years ago

lgtm. Thanks!