search

datastax / cstar_perf

Apache Cassandra performance testing platform
Apache License 2.0
72 stars 34 forks source link

CSTAR-553: report back Cassandra startup log #211

Closed nastra closed 8 years ago

nastra commented 8 years ago

This PR will now copy/report back the startup log (nohup.out) of the Cassandra node. That way it's possible to check e.g. why the JVM startup failed.

The below picture is from a successful JVM startup + test run. Both test revisions contain now the startup log: successful_test_run

The below picture is from a non-successful run. It shows that the first revision was running fine, but the second revision failed due to invalid JVM settings. Therefore in the second revision we only have the startup log: not_successful_test_run

mshuler commented 8 years ago

This looks good to me, thanks!

mambocab commented 8 years ago

I'm +1 on the concept. If you've run locally and it works, I'm +1, though I'd prefer you address my comments. Up to you though, my comments aren't super-important.

nastra commented 8 years ago

@mambocab @mshuler thanks for the review. I'll provide a follow up commit that addresses all comments

nastra commented 8 years ago

@mambocab @mshuler pushed some new changes with all comments being addressed

mambocab commented 8 years ago

:+1: Thanks!