search

datastax / cstar_perf

Apache Cassandra performance testing platform
Apache License 2.0
72 stars 34 forks source link

Use fixed names for cstar_perf component logs. #212

Closed nastra closed 8 years ago

nastra commented 8 years ago

The reason why we want to have fixed names instead of the generated log file names (/tmp/cstar_perf_X-), is that once a cstar_perf component is restarted, the log file with the generated name will be overwritten and lost. However, after a restart we would like to be able to still preserve the log file.

mambocab commented 8 years ago

I don't know much about supervisord -- so, after a restart, will the new process continue appending to the same log file?

mshuler commented 8 years ago

It looks like rotation is set up with logfile_maxbytes and logfile_backups in [supervisord] block, and with stderr_logfile_maxbytes and stderr_logfile_backups in [child_program] blocks. Thanks for this suggestion! I needed to go dig up how rotation was configured before attempting this, otherwise we tank servers pretty quickly with full disks. http://supervisord.org/logging.html#activity-log-rotation

nastra commented 8 years ago

@mambocab yes, after a restart the cstar_perf component will continue to e.g. append stuff to /tmp/cstar_perf_client.log. In fact, I'm already using those changes on our DSE cstar_perf instance and they work as expected.

mambocab commented 8 years ago

Awesome, thanks for the confirmation. +1 from me.

nastra commented 8 years ago

@mshuler is that one good to merge from your side?

mshuler commented 8 years ago

Yes, +1. I can add rotation where needed.