Closed belliottsmith closed 9 years ago
yep, will fix tonight On Sep 15, 2015 5:01 PM, "Ryan McGuire" notifications@github.com wrote:
Assigned #95 https://github.com/datastax/cstar_perf/issues/95 to @aboudreault https://github.com/aboudreault.
— Reply to this email directly or view it on GitHub https://github.com/datastax/cstar_perf/issues/95#event-410283795.
The JVM selector is also broken in #93. We should probably fix it there instead of on master, because that PR is almost ready to merge anyway.
I assume it has been rebased since the DSE work? I'll setup that branch locally and fix it there. On Sep 15, 2015 6:42 PM, "Ryan McGuire" notifications@github.com wrote:
The JVM selector is also broken in #93 https://github.com/datastax/cstar_perf/pull/93. We should probably fix it there instead of on master, because that PR is almost ready to merge anyway.
— Reply to this email directly or view it on GitHub https://github.com/datastax/cstar_perf/issues/95#issuecomment-140568946.
Yea, I did the rebase yesterday on top of DSE changes On Sep 15, 2015 6:45 PM, "Alan Boudreault" notifications@github.com wrote:
I assume it has been rebased since the DSE work? I'll setup that branch locally and fix it there. On Sep 15, 2015 6:42 PM, "Ryan McGuire" notifications@github.com wrote:
The JVM selector is also broken in #93 https://github.com/datastax/cstar_perf/pull/93. We should probably fix it there instead of on master, because that PR is almost ready to merge anyway.
— Reply to this email directly or view it on GitHub <https://github.com/datastax/cstar_perf/issues/95#issuecomment-140568946 .
— Reply to this email directly or view it on GitHub https://github.com/datastax/cstar_perf/issues/95#issuecomment-140569388.
It might be a good idea to also make the latest java8 the default jvm for new tests. On Sep 15, 2015 6:50 PM, "Ryan McGuire" ryan@datastax.com wrote:
Yea, I did the rebase yesterday on top of DSE changes On Sep 15, 2015 6:45 PM, "Alan Boudreault" notifications@github.com wrote:
I assume it has been rebased since the DSE work? I'll setup that branch locally and fix it there. On Sep 15, 2015 6:42 PM, "Ryan McGuire" notifications@github.com wrote:
The JVM selector is also broken in #93 https://github.com/datastax/cstar_perf/pull/93. We should probably fix it there instead of on master, because that PR is almost ready to merge anyway.
— Reply to this email directly or view it on GitHub < https://github.com/datastax/cstar_perf/issues/95#issuecomment-140568946>.
— Reply to this email directly or view it on GitHub https://github.com/datastax/cstar_perf/issues/95#issuecomment-140569388 .
Fixed in #93.
Great. Thanks!
Seems to get reset to oldest JDK 1.7 - this is only a tiny bug, but is bound to catch people out