search

datastax / cstar_perf

Apache Cassandra performance testing platform
Apache License 2.0
72 stars 34 forks source link

GUI should help make sure comparisons are against the same baseline #97

Open belliottsmith opened 9 years ago

belliottsmith commented 9 years ago

Right now (especially close to release) we're having problems with patches with different baselines being compared to each other. It would be great if cstar presented the most recent SHA commits for you to select from for a given branch, so that when the test is actually run we know for certain they were compared like-for-like.

aboudreault commented 9 years ago

I could probably do something similar to what I've done with stress_revision for this. At startup, I replace the revision name by their SHA.

belliottsmith commented 9 years ago

It would be helpful to show it to the user, though, so that they actually check the branches haven't diverged too much. Perhaps just showing the SHA you will pick, along with the last 5 commit messages would be enough - if they're out of whack, they can fiddle with the SHAs / rebase themselves.

EnigmaCurry commented 9 years ago

I would recommend we do this entirely client side via the github API, that way we can stay away from needing to check out each branch on the frontend.

EnigmaCurry commented 9 years ago

I've been thinking about how to refactor how we specify revisions as a whole. Please see #98.

I think the changes here would follow nicely on that.

For example, you could start typing in the revision box : "belliottsmith/". As soon as you type that '/' the browser could do an ajax call to this API : https://developer.github.com/v3/repos/commits/ and display the recent commits in a drop down box for that branch.

belliottsmith commented 9 years ago

That sounds neat, yeah. If it could scope it by branch and then, within that branch, the individual recent commits (with their messages) it would be really awesome.

On 16 September 2015 at 18:10, Ryan McGuire notifications@github.com wrote:

I've been thinking about how to refactor how we specify revisions as a whole. Please see #98 https://github.com/datastax/cstar_perf/issues/98.

I think the changes here would follow nicely on that.

For example, you could start typing in the revision box : "belliotsmith/". As soon as you type that '/' the browser could do an ajax call to this API : https://developer.github.com/v3/repos/commits/ and display the recent commits in a drop down box for that branch.

— Reply to this email directly or view it on GitHub https://github.com/datastax/cstar_perf/issues/97#issuecomment-140806824.