search

datastax / diagnostic-collection

Diagnostic Collector for Apache Cassandra
Apache License 2.0
28 stars 35 forks source link

Minor fix to correctly filter Cassandra nodes from bastion host #120

Closed joelsdc closed 2 years ago

joelsdc commented 2 years ago

Currently when a running the discovery phase the script checks for Cassandra nodes and exits if detects a match: https://github.com/datastax/diagnostic-collection/blob/744e043562abfc145aa2e9fb4642209e2778c8c0/ds-collector/ds-collector#L147-L151

Say, for example, you have a 15 Cassandra node cluster, with IPs:

192.168.0.1/24
...
192.168.0.15/24

And your bastion host has the IP 192.168.0.100

When running the above check, the bastion IP of 192.168.0.100 would be a match with Cassandra node 192.168.0.10 and thus the script errors out.

This patch fixes that.

joelsdc commented 2 years ago

Added!

michaelsembwever commented 2 years ago

@mieslep do you wanna eyeball this too?