search

datastax / diagnostic-collection

Diagnostic Collector for Apache Cassandra
Apache License 2.0
28 stars 35 forks source link

when encrypt_uploads, verify md5 of .key file and attempt to fix before failing #130

Closed mieslep closed 2 years ago

mieslep commented 2 years ago

A number of .enc artifacts have been uploaded but have been unable to be decrypted. It appears a common failure is added DOS line endings \r. To protect against this a Reuben enhancement is requested to add an md5 checksum of the .key file.

If encrypted uploads to S3 are enabled, verify that the .key file is as expected. If it is not, attempt to get it to match by stripping \r from the file. If it still does match, fail with a clear explanation.

michaelsembwever commented 2 years ago

To protect against this a Reuben enhancement is requested to add an md5 checksum of the .key file.

Everything can be done in the repo.

michaelsembwever commented 2 years ago

Being worked on in https://github.com/datastax/diagnostic-collection/pull/139