search

datastax / diagnostic-collection

Diagnostic Collector for Apache Cassandra
Apache License 2.0
28 stars 36 forks source link

Add encryption and S3 uploads support #20

Closed adejanovski closed 3 years ago

adejanovski commented 3 years ago

The PR is available for review. It allows to encrypt the diagnostic tarball and upload it directly to S3. The encryption key is generated automatically if it's missing.

These features were added in a separate shell script which can be invoked individually or through collect_diag.sh if some new arguments are provided.

I've had issues with the way the top directory of the distribution was passed to handle tarball installs. It was using $1 instead of a flagged argument like the other options, and that lead to issues in parsing the options in some cases. I then had to make a breaking change and introduce the -P /path/to/tarball_top_directory/ option to pass that value.

Let me know if that's ok.

Appropriate additions were made to the integration tests to check that the S3 upload works as expected.

adejanovski commented 3 years ago

@msmygit, let me know what you think about the breaking change on passing the root directory for tarball installs. I'd like your opinion on this before merging.