datastax / pulsar-helm-chart

Apache Pulsar Helm chart
Apache License 2.0
46 stars 38 forks source link

Upgrade Luna Streaming image to 2.8.0.1.1.43 #222

Closed nicoloboschi closed 2 years ago

nicoloboschi commented 2 years ago

checks failed in this way:

Error installing charts: Error identifying charts to process: Must be in a git repository
Error: Error installing charts: Error identifying charts to process: Must be in a git repository
Removing ct container...
Done!

I don't think it is related to my pull @lhotari @michaeljmarshall

michaeljmarshall commented 2 years ago

@nicoloboschi - I agree that these failures are unrelated to your PR, I'll take a look.

michaeljmarshall commented 2 years ago

@nicoloboschi - I see that the logs indicate No chart changes detected.. I didn't think we were requiring chart changes for tests to pass, but that's why these tests failed.

michaeljmarshall commented 2 years ago

I fixed the issue in #224.

michaeljmarshall commented 2 years ago

The tests weren't passing even after closing and reopening. This is a trivial change. Merging now and will verify that the tests on master pass.