Closed nicoloboschi closed 2 years ago
@nicoloboschi - I agree that these failures are unrelated to your PR, I'll take a look.
@nicoloboschi - I see that the logs indicate No chart changes detected.
. I didn't think we were requiring chart changes for tests to pass, but that's why these tests failed.
I fixed the issue in #224.
The tests weren't passing even after closing and reopening. This is a trivial change. Merging now and will verify that the tests on master pass.
checks failed in this way:
I don't think it is related to my pull @lhotari @michaeljmarshall