search

datastax / pulsar-helm-chart

Apache Pulsar Helm chart
Apache License 2.0
46 stars 38 forks source link

BrokerSts: brokerWebServiceURLTLS is not empty on proxy even if you don't enable TLS #238

Open eolivelli opened 2 years ago

eolivelli commented 2 years ago

I have noticed that if you enable brokerSts and you don't enable TLS the helm chart still populates brokerWebServiceURLTLS. This shouldn't be a problem because you have to set tlsEnabledWithBroker but it is very difficult to understand.

Actually it revealed a bug in Starlight for Kafka, that assumed that if brokerWebServiceURLTLS is non empty, then it is a valid URL to connect to the brokers.

eolivelli commented 2 years ago

I have also noticed a typo here: https://github.com/datastax/pulsar-helm-chart/blob/master/helm-chart-sources/pulsar/templates/proxy/proxy-ws-configmap.yaml#L34

in this file we use both brokerServiceURL and brokerServiceUrl the correct spelling should be brokerServiceURL according to the Java source

eolivelli commented 2 years ago

for reference: https://github.com/datastax/starlight-for-kafka/pull/16