search

datastax / pulsar-helm-chart

Apache Pulsar Helm chart
Apache License 2.0
47 stars 37 forks source link

Broker statefulset no accounted for in PulsarSQL configmap #267

Open ddieruf opened 2 years ago

ddieruf commented 2 years ago

The pulsarSql configmap assumes broker is a deployment by using .Values.broker.component https://github.com/datastax/pulsar-helm-chart/blob/014a542e11cd01843c7e7fe65d88314d6da33a99/helm-chart-sources/pulsar/templates/pulsarSql/configmap-coordinator.yaml#L75

When using brokerSts, PulsarSql can not find the broker because it's .Values.brokerSts.component.

michaeljmarshall commented 2 years ago

Thanks for opening this issue @ddieruf. I think there are multiple places in the helm chart with this bug. the easiest solution is to configure .Values.brokerSts.component: broker. A better solution would use a templating function to figure out the "right" component name to use without duplicating the logic everywhere. Is this issue blocking you? Are you interested in contributing a fix?

ddieruf commented 2 years ago

I'll just use the workaround for now, thx.

On Tue, Nov 15, 2022 at 11:24 AM Michael Marshall @.***> wrote:

Thanks for opening this issue @ddieruf https://github.com/ddieruf. I think there are multiple places in the helm chart with this bug. the easiest solution is to configure .Values.brokerSts.component: broker. A better solution would use a templating function to figure out the "right" component name to use without duplicating the logic everywhere. Is this issue blocking you? Are you interested in contributing a fix?

— Reply to this email directly, view it on GitHub https://github.com/datastax/pulsar-helm-chart/issues/267#issuecomment-1315556096, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBJG3BANZ45FTEGBBAJ353WIO2LJANCNFSM6AAAAAASBBQT54 . You are receiving this because you were mentioned.Message ID: @.***>