WIP: Cherry-picks from KOP, do not squash

[dlg99]

$ for s in `git cherry -v HEAD kop/master kop/master~10 | grep -v maven-release-plugin | cut -c 3-42`; do check=`git log --grep="cherry picked from commit $s"`; check2=`git log | grep="$s"`; [ -z "$check" ] && [ -z "$check2" ] && echo $s ;  done

082e583aadb3ede566c73c916aae9656c3d75d52
c7cb1cf5f5c5b6aebebeffdf18020ff6baabe059
4d4729f238943bccb3f93550b82282448b65721d
e58b7b9deb02f5e925725e4183bcf183b4f03007
9b01854e42d842dd557fb0f7937426e5babd5259
68cfcc44bd5077ea0bee1609096aa660b01ccfcc
c3336be05700ab388dda9797850d9ca290b3f645
c0ece19f5dede37576ba728169a33f19f43cc310
0d2ed74c56176dd17b9bf3a83f1f89a6a1653ea9

so far:

082e583aadb3ede566c73c916aae9656c3d75d52 - skipped (sources version upgrade for javadoc plugin)
c7cb1cf5f5c5b6aebebeffdf18020ff6baabe059 - ok
4d4729f238943bccb3f93550b82282448b65721d - resolved
e58b7b9deb02f5e925725e4183bcf183b4f03007 - resolved
9b01854e42d842dd557fb0f7937426e5babd5259 - autoresolved
68cfcc44bd5077ea0bee1609096aa660b01ccfcc - already in (cherry-picked form s4k to kop)
c3336be05700ab388dda9797850d9ca290b3f645 - ok
c0ece19f5dede37576ba728169a33f19f43cc310 - ok
0d2ed74c56176dd17b9bf3a83f1f89a6a1653ea9 - had to revert/resolve 9e4d07f4ea2a22d6e828e809fbb0430fd72b46fb, 
     cherry-pick and resolve this one, then cherry-pick/resolve 9e4d07f4ea2a22d6e828e809fbb0430fd72b46fb back

KafkaRequestHandlerProxyTest/KafkaRequestHandlerTest were failing, looks like related to changes in the tests. Cherry-picked and resolved f0eda8e73e2a1e51d41562318c948024418534ae

KafkaAdminTest added there fails :confused:

• list topics returns internal (__blah) topics. Filtered these out in the test but I need help from someone who understands if any of our changes make this expected
• "org.apache.kafka.common.errors.UnsupportedVersionException: The version of API is not supported." in testAlterClientQuotas :confused: Marked this one as ignored,.

Bunch of test cases moved from KafkaRequestHandlerTest to KafkaAdminTest

[codecov-commenter]

Codecov Report

Merging #88 (aa6ea13) into 2.10_ds (f0a1ceb) will increase coverage by 54.46%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

[](https://app.codecov.io/gh/datastax/starlight-for-kafka/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datastax) ```diff @@ Coverage Diff @@ ## 2.10_ds #88 +/- ## ============================================== + Coverage 0 54.46% +54.46% - Complexity 0 118 +118 ============================================== Files 0 19 +19 Lines 0 940 +940 Branches 0 80 +80 ============================================== + Hits 0 512 +512 - Misses 0 411 +411 - Partials 0 17 +17 ``` [see 19 files with indirect coverage changes](https://app.codecov.io/gh/datastax/starlight-for-kafka/pull/88/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datastax)

[dlg99]

@eolivelli I think it will be easier to look at this commit by commit