search

datastorm-open / rAmCharts

API for Amcharts
48 stars 16 forks source link

recycle dp$color to pass data.table 1.12.2 #89

Closed mattdowle closed 5 years ago

mattdowle commented 5 years ago

Dear Benoit,

You were one of 16 maintainers I emailed on 24th Jan. You were one of the 3 I didn't hear back from. Hopefully this change in data.table is ok with you. Background : https://twitter.com/MattDowle/status/1088544083499311104 https://github.com/Rdatatable/data.table/pull/3310 https://github.com/Rdatatable/data.table/issues/3347

I've run R CMD check on rAmCharts with this PR (just one line needs change) and it passes ok. Will it be ok for you to update rAmCharts on CRAN?

Best, Matt

bthieurmel commented 5 years ago

Hi Matt,

I’ve read the discussion and I agree with this change, but I’m just not a twitter user...!

rAmCharts is on his way on CRAN.

And many thanks for your time and the great package data.table.

Benoit.