search

datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.
https://datastorm-open.github.io/shinymanager/
386 stars 79 forks source link

Way to disable users db and logs download #113

Closed StatisMike closed 2 years ago

StatisMike commented 3 years ago

Adressing issue #110. Adds download argument to secure_app function, which defaults to c("users", "logs"), allowing the respective downloads from admin panel. To disable both, you can set download = NULL.

Also, minor typo mistake correction in polish labels.

StatisMike commented 3 years ago

Need another implementation for additional security (not only not showing the downloadButtons, but also disabling downloadHandlers)

StatisMike commented 3 years ago

Option to download db and logs depends on options("shinymanager.download") value that defaults to c("db", "logs"). To disable both specify options("shinymanager.download" = "")

StatisMike commented 3 years ago

@bthieurmel Can I request a review and - if everything is ok - pull?

bthieurmel commented 2 years ago

Hi @StatisMike : Can I check / review your pull request and merge if ok ?

StatisMike commented 2 years ago

@bthieurmel Certainly!

f-leborgne commented 2 years ago

Hi, I added options("shinymanager.download" = "") at the beginning of the code of my shiny app but the download button is still present. I have the version 1.0.400 of the shinymanager package installed from the cran Thanks for your help

StatisMike commented 2 years ago

@f-leborgne AFAIK the pull request wasn't accepted yet. Even if this will get accepted, you will need to download development version from GitHub, I presume