search

datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.
https://datastorm-open.github.io/shinymanager/
381 stars 79 forks source link

Font-Awesome Warnings #117

Closed dmenne closed 2 years ago

dmenne commented 3 years ago

Using shinymanager 1.0.400 with shiny 1.6.0.92021, I get the warnings below when shinymanager is active. I know these Fonts are moving targets, and even core Shiny does not stay up-to-date, see a similar issue (https://community.rstudio.com/t/use-of-open-source-icons-in-shiny/110056)

However, I think this can be solved easily by using some other icon here. Trial-and-error, though, to find which ones are available.


Listening on http://127.0.0.1:3838
The `name` provided ('sign-out') is deprecated in Font Awesome 5:
* please consider using 'sign-out-alt' or 'fas fa-sign-out-alt' instead
* use the `verify_fa = FALSE` to deactivate these messages
This Font Awesome icon ('close') does not exist:
* if providing a custom `html_dependency` these `name` checks can 
  be deactivated with `verify_fa = FALSE`
pvictor commented 2 years ago

Icon management will change in the next version of shiny, it'll be powered by package {fontawesome}, you should raise this issue there, that's not related to {shinymanager}.

ismirsehregal commented 2 years ago

@pvictor a related post came up on SO.

Shouldn't e.g. icon("close") be replaced by icon("times") in this case?

icon("close")
# This Font Awesome icon ('close') does not exist:
# * if providing a custom `html_dependency` these `name` checks can 
#   be deactivated with `verify_fa = FALSE`
icon("times")

Cheers!

pvictor commented 2 years ago

You're right @ismirsehregal it should be replaced, are you willing to make a PR ?

ismirsehregal commented 2 years ago

@pvictor sure https://github.com/datastorm-open/shinymanager/pull/130 should fix all the warnings. Cheers