Avoid Font-awesome deprecation warnings

datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.

https://datastorm-open.github.io/shinymanager/

386 stars 79 forks source link

Avoid Font-awesome deprecation warnings #148

Closed dmenne closed 2 years ago

dmenne commented 2 years ago

Change all names that gave a warning to current ones, e.g

The `name` provided ('sign-out') is deprecated in Font Awesome 6:
* please consider using 'right-from-bracket' or 'fas fa-right-from-bracket' instead
* use the `verify_fa = FALSE` to deactivate these messages

ismirsehregal commented 2 years ago

I guess you missed my PR?

dmenne commented 2 years ago

Yes, I had done the changes for my own use and only later realized there was already one. Now lets hope that one of these is included

ismirsehregal commented 2 years ago

I just checked your branch via my script provided here.

It seems you missed a few icon calls:

Cheers