search

datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.
https://datastorm-open.github.io/shinymanager/
379 stars 79 forks source link

Use shinyjs in the authorisation page of a shinymanager app #160

Open pepijn-devries opened 1 year ago

pepijn-devries commented 1 year ago

Hi there,

Thank you for your work on shinymanager! I have the following problem when using javascript in shiny apps in combination with a secure_app from shinymanager.

When using javascript in Shiny apps, the shinyjs is the default (at least for me). It has been a struggle to figure out where to place the shinyjs::useShinyjs() call in order to use javascript at the authorisation page., Eventually I've figured out that I had to pass this call via the head_auth argument.

I've reported this issue earlier at shinyjs, but its developer (@daattali) and I came to the conclusion that it would be handled best by improving the documentation of the shinymanager package. See closed issue and pull request: https://github.com/daattali/shinyjs/issues/258 and https://github.com/daattali/shinyjs/pull/259.

Hopefully, you can look into this.

Kind regards,

Pepijn

sanjmeh commented 1 year ago

If only the shinymanager documentation is improved a bit.. it is a terrific idea to wrap another shiny app for security purposes.