datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.
https://datastorm-open.github.io/shinymanager/
388 stars 78 forks source link

Add support to Brazilian Portuguese #17

Closed erikson84 closed 4 years ago

pvictor commented 4 years ago

Thanks @erikson84 for the PR, I removed non-ASCII characters to avoid R CMD warnings, I think it's good now.

bthieurmel commented 4 years ago

Hi @erikson84 and thanks for your PR.

Can you confirm or not that in fact this is more globally a Portuguese support or there is a some strong diffrence between Portuguese and Brazilian portuguese ?

erikson84 commented 4 years ago

@bthieurmel , most software packages distinguish between brazilian portuguese and portuguese. On the other hand, I believe a non-brazilian portuguese speaker would have no problem understanding the text.

bthieurmel commented 4 years ago

Ok. So keep br. Now merge on master, and on CRAN soon.

Thanks