Internet explorer doesn't support the method 'includes'

datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.

https://datastorm-open.github.io/shinymanager/

388 stars 78 forks source link

Internet explorer doesn't support the method 'includes' #18

Closed conrad-mac closed 4 years ago

conrad-mac commented 4 years ago

When trying to run an app with shinymanager in internet explorer, neither the logout nor timeout functions work. The error in the console is below. This actually crashes the running of JavaScript in my app and so doesn't load the select input element etc. No problems on Chrome or Edge, however.

pvictor commented 4 years ago

Hello, Yes includes is indeed not available in IE, we can use array.indexOf(i) !== -1 or a polyfill ( as defined here : https://mariusschulz.com/blog/ecmascript-2016-array-prototype-includes

bthieurmel commented 4 years ago

Hi, this is fixed on dev version.

conrad-mac commented 4 years ago

I can confirm that this change has fixed my issue. Thanks so much for the quick response!