datastorm-open / shinymanager

Simple and secure authentification mechanism for single shiny applications.
https://datastorm-open.github.io/shinymanager/
381 stars 79 forks source link

WIP - Admin mode: edit multiple users #95

Closed pvictor closed 3 years ago

pvictor commented 3 years ago

WIP

Goal: allow to edit multiple users at the same time

All columns in credentials can be edited EXCEPT:

I added a check to ensure that the new value provided is isTruthy, so if an input is blank, the value won't be updated (this prevent to update columns that we don't want to modify)

I removed pagination in users' table to display all users and allow scrolling because the "select all users" doesn't work with pagination.

I'll make some tests in my use-case before we can consider to merge this functionnality

pvictor commented 3 years ago

Hey @bthieurmel , that should be ok if you want to give a look

bthieurmel commented 3 years ago

Hi @pvictor,

I've some kind of problem with isTruthy controlling not null value because some times, we want to reset / set the value as NULL / NA, for example if you want to cancel a limitation date

bthieurmel commented 3 years ago

Perhaps, we can think about adding a checkbox authorising setting NULL value ? Both for single and multiple edit ? And so control or not with isTruthy