search

datastrato / gravitino-playground

A playground to experience Gravitino
Apache License 2.0
18 stars 11 forks source link

[#34] add spark connector to playground #45

Open FANNG1 opened 2 weeks ago

FANNG1 commented 2 weeks ago

add spark connector to playground

FANNG1 commented 2 weeks ago

@qqqttt123 , could you help to review when you free?

jerqi commented 1 week ago

There are some issues.

  1. Trino and Spark will init the metalake twice.
  2. Is there the conflict if we want to use Spark rest catalog and Spark connector at the same time?
  3. Do you need a case about Spark connector?
FANNG1 commented 1 week ago

There are some issues.

  1. Trino and Spark will init the metalake twice.

the script checks the exist of metalake and catalogs before creating it.

  1. Is there the conflict if we want to use Spark rest catalog and Spark connector at the same time?

no, I changed the rest catalog name to avoid conflict.

  1. Do you need a case about Spark connector?

no, it's out of the scope of this PR

jerqi commented 1 week ago

You should include the case. Because it's the verification about the Spark connector.

FANNG1 commented 1 week ago

You should include the case. Because it's the verification about the Spark connector.

this pr only focus on add spark connector to playground, we could use another pr to do it

jerqi commented 1 week ago

You should include the case. Because it's the verification about the Spark connector.

this pr only focus on add spark connector to playground, we could use another pr to do it

You should add the document or you add the steps of your test at least. Otherwise, I don't how to verify this pull request.

FANNG1 commented 1 week ago

You should include the case. Because it's the verification about the Spark connector.

this pr only focus on add spark connector to playground, we could use another pr to do it

You should add the document or you add the steps of your test at least. Otherwise, I don't how to verify this pull request.

so, I propose another PR in Gravitino playground document?