Closed Clearvive closed 4 months ago
@mchades @FANNG1 Can you help me review it?
@jerryshao Can you help me review it?
could you explain the reason why add ENGINE
, DEFAULT CHARSET
, COLLATE
and AUTO_INCREMENT
to Mysql table properties meta to be managed by Gravitino.
do you support change table properies or remove table properties ?
could you explain the reason why add
ENGINE
,DEFAULT CHARSET
,COLLATE
andAUTO_INCREMENT
to Mysql table properties meta to be managed by Gravitino.
It's solely because these four attributes are common and frequently used values in production.
e
Not supported
could you explain the reason why add
ENGINE
,DEFAULT CHARSET
,COLLATE
andAUTO_INCREMENT
to Mysql table properties meta to be managed by Gravitino.It's solely because these four attributes are common and frequently used values in production.
I don't see a strong reason, especially for DEFAULT CHARSET
COLLATE
, suggest to explain more in Why the changes are needed
e
Not supported
seems we should support change table properites ?
could you explain the reason why add
ENGINE
,DEFAULT CHARSET
,COLLATE
andAUTO_INCREMENT
to Mysql table properties meta to be managed by Gravitino.It's solely because these four attributes are common and frequently used values in production.
I don't see a strong reason, especially for
DEFAULT CHARSET
COLLATE
, suggest to explain more inWhy the changes are needed
Explicitly setting the default character set ensures that all character data in the table uses the same character encoding. This helps to avoid issues such as garbled characters or inconsistencies that may arise when using different character encodings in a mixed environment.
e
Not supported
seems we should support change table properites ? We support modifying table properties
I failed to retrive the properies from JDBC drivers, but instead of querying data from internal system table, I prefer to use SHOW TABLE STATUS WHERE Name = 'xx'
to get the properties, seems more maintanable.
LGTM, except the few comments
LGTM, except the few comments
@jerryshao Can you help review it?
It's okay for me and have not further comments.
@FANNG1 @yuqi1129 you can go ahead if you feel OK.
Besides, we need to also update the doc @Clearvive
What changes were proposed in this pull request?
Support mysql table properties.
Why are the changes needed?
Fix: #804
Does this PR introduce any user-facing change?
Add mysql properties support.
How was this patch tested?
UT/IT