[#738]:Dependencies follow alphabetical order

[hiirrxnn]

What changes were proposed in this pull request?

Dependencies follow alphabetical order

Why are the changes needed?

For better readability Fix: #738

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

[hiirrxnn]

Please take a look , if this looks good , I will do the same for all subsequent build.gradle.kts files . This is just a demo.

[justinmclean]

you need to run ./gradlew :catalogs:catalog-lakehouse-iceberg:spotlessApply to fix a formatting issue.

[justinmclean]

Look good, but I think you may have moved a little too much around. It's just the content inside the dependencies block that needs to change.

[hiirrxnn]

Look good, but I think you may have moved a little too much around. It's just the content inside the dependencies block that needs to change.

Could you mark in the files changed where I changed something I shouldn't have ,so that its clear. Should I not rearrange the 'exclude(xx)' dependencies.

[yuqi1129]

@hiirrxnn Do you need help? I suggest you run "./gradlew build -DskipTests -DskipITs" before pushing code to GitHub to ensure everything is OK locally.

[hiirrxnn]

I have run the said command in check details but the issue persists.

[yuqi1129]

@hiirrxnn You still have some fomat issues. can you provide your local environment:

• IDE you use and related-configuration like space and tabs as follows

  

• JDK version

• Local OS

• and so on.

[hiirrxnn]

I'm currently using VS Code IDE , JDK version : openjdk version "17.0.6" 2023-01-17 OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10) OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode) , and MacOS Sonoma 14.2.1 operating system

[hiirrxnn]

Should i use a specific IDE or formatting conditions ? Please let me know

[yuqi1129]

Should i use a specific IDE or formatting conditions ? Please let me know

No, I don't think the project should be limited to a specific IDE or formatting settings. I noticed that CI is now okay.

[hiirrxnn]

I will commit/push each edited file , so that it's easy to pinpoint which one is causing the error.

[hiirrxnn]

This push is a draft , I will review it if any CI fails.

[justinmclean]

You need to run ./gradlew :core:spotlessKotlinGradleCheck

[hiirrxnn]

CI is still failing .Could you help me pinpoint which specific files are causing the problem ?

[justinmclean]

If you look at the details you'll see it will tell you where it is failing in this case, you need to run ./gradlew :server:spotlessApply, running ./gradlew build -x test locally would also give you the same error, so it's best to do that first before pushing your changes.

[yuqi1129]

CI is still failing .Could you help me pinpoint which specific files are causing the problem ?

Here is the patch. Please take a look. patch.txt

[jerryshao]

Thanks @hiirrxnn for the PR. @yuqi1129 @qqqttt123 do you have further comments?

[yuqi1129]

Thanks @hiirrxnn for the PR. @yuqi1129 @qqqttt123 do you have further comments?

I'm okay with the changes.

[hiirrxnn]

I still have one file remaining to sort , since because of it CI was failing , I pushed it untouched and will edit it once you guys approve the current changes Let me know if there are other improvements to be made.

[yuqi1129]

I still have one file remaining to sort , since because of it CI was failing , I pushed it untouched and will edit it once you guys approve the current changes Let me know if there are other improvements to be made.

Hi, Is your local environment Windows? Can you help try this https://github.com/datastrato/gravitino/pull/1976#discussion_r1477033104, Still we haven't tested the spotless plugin with Windows comprehensively

[hiirrxnn]

I'm sorry but I use MacOS.

[yuqi1129]

@hiirrxnn Could you please resolve the conflicts?

[hiirrxnn]

Sure

[yuqi1129]

@hiirrxnn Thank you for your contributions.