[#2434] Improvement: if DropXXX success, return true, if not exists return false - Githubissues

datastrato / gravitino

World's most powerful data catalog service with providing a high-performance, geo-distributed and federated metadata lake.

https://datastrato.ai/docs/

Apache License 2.0

347 stars 150 forks source link

[#2434] Improvement: if DropXXX success, return true, if not exists return false #3222

Open charliecheng630 opened 2 weeks ago

charliecheng630 commented 2 weeks ago

What changes were proposed in this pull request?

When dropping the XXX(Metalake/Catalog/Schema/Table/Fileset/Partition/Topic), if the XXX does not exist, then return false.

Why are the changes needed?

a clear drop behavior of return value and exception thrown.

Fix: #2434

Does this PR introduce any user-facing change?

No

How was this patch tested?

ITs and UTs

jerryshao commented 1 week ago

@mchades would you please help to review this?

mchades commented 1 week ago

Are the changes in core module the same as #3100 ?

charliecheng630 commented 1 week ago

Are the changes in core module the same as #3100 ?

Yes.

charliecheng630 commented 1 week ago

Update. Please help to review again when you have time~

charliecheng630 commented 1 week ago

Updated. Please help to review again when you have time, thanks!

charliecheng630 commented 1 week ago

@mchades Updated. Please help to review again when you have time, thanks!

jerryshao commented 1 week ago

@charliecheng630 would you please rebase the code?

jerryshao commented 1 week ago

@charliecheng630 can you please also confirm that if anything should be changed in the client side?