search

datastrato / gravitino

World's most powerful data catalog service with providing a high-performance, geo-distributed and federated metadata lake.
https://datastrato.ai/docs/
Apache License 2.0
347 stars 150 forks source link

[#3209]test(web): doris web e2e test #3230

Closed LauraXia123 closed 4 days ago

LauraXia123 commented 2 weeks ago

What changes were proposed in this pull request?

Add test create doris catalog to the web e2e test

Why are the changes needed?

Fix: #3209

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

manual

yuqi1129 commented 2 weeks ago

@LauraXia123 I have solved the problem related to Doris, there still some issues about fornt-end test, please take a look.

LauraXia123 commented 1 week ago

@yuqi1129 Thanks a lot. I'll check the left issues.

LauraXia123 commented 1 week ago

All the test case have passed, but I can't start the doris container locally, can you try it locally for me? @xunliu

zhoukangcn commented 1 week ago

All the test case have passed, but I can't start the doris container locally, can you try it locally for me? @xunliu

@LauraXia123 Did you start doris successfully? If you still have problem, I can help

LauraXia123 commented 1 week ago
image image

@zhoukangcn You can take a look my stack information above.

zhoukangcn commented 1 week ago

@LauraXia123 you can exec command docker images|grep doris to make sure doris Image exist (datastrato/gravitino-ci-doris:0.1.3)

If Doris Image not exist, you can use command docker pull datastrato/gravitino-ci-doris:0.1.3 before CI

If Doris Image exist, you can see log in catalogs/catalog-jdbc-doris/build , include testcontainers.log, catalog-jdbc-doris-integration-test.log and send it to me

LauraXia123 commented 1 week ago

The image is exist but not log files.

image image
yuqi1129 commented 5 days ago

Please move on for this PR, thanks.

yuqi1129 commented 5 days ago

@xunliu Please help to take a review if you have time, thanks.

xunliu commented 4 days ago

@LauraXia123 You can setting 16GB memory in the Docker, if CI running in you local success, then we can merge this PR.

LauraXia123 commented 4 days ago

I can run it success this morning

image
xunliu commented 4 days ago

@LauraXia123 Thank you for your contributions. LGTM

jerryshao commented 3 days ago

Again @xunliu , please follow the steps in MAINTAINERS.md when merging the PR. I really don't want to say this again and again. Merging a PR is very simple, but it will cost time when doing a release without following the steps. You have to a) weigh the necessity to backport; b) add necessary tags.