Closed caican00 closed 5 days ago
Hi @FANNG1 could you help review this pr? thank you.
all comments have been addressed. cc @FANNG1
all comments have been addressed except one in discussion. cc @FANNG1
@jerryshao @qqqttt123 do you have time to review? Overall LGTM except minor comment.
@FANNG1 all comments have been addressed.
If this is a user-facing change, you should add the documents.
If this is a user-facing change, you should add the documents.
done.
@FANNG1 could you help review again?
@caican00 could you fix the conflict?
@qqqttt123 do you have other comments?
@caican00 could you fix the conflict?
done
Hi @FANNG1 @qqqttt123 are there any else comments to fix?
Hi @FANNG1 @qqqttt123 are there any else comments to fix?
LGTM,will merge the PR if no other comments this afternoon
@caican00 great process for supporting the Iceberg catalog, thanks for your work.
What changes were proposed in this pull request?
refactor table implementation, make
SparkIcebergTable
extend IcebergSparkTable
, andSparkHiveTable
extend KyuubiHiveTable
.support row-level operations to iceberg Table
Why are the changes needed?
For spark-connector in Iceberg, it explicitly uses
SparkTable
to identify whether it is an Iceberg table, so theSparkIcebergTable
must extendSparkTable
.support row-level operations to iceberg Table.
Fix: https://github.com/datastrato/gravitino/issues/2543
Does this PR introduce any user-facing change?
Yes, support update ... , merge into ..., delete from ...
How was this patch tested?
New ITs.