[Improvement] assertThat should do that

datastrato / gravitino

World's most powerful data catalog service with providing a high-performance, geo-distributed and federated metadata lake.

https://datastrato.ai/docs/

Apache License 2.0

347 stars 150 forks source link

[Improvement] assertThat should do that #3251

Closed justinmclean closed 1 week ago

justinmclean commented 2 weeks ago

What would you like to be improved?

AssertThat should be followed by an assertion, however assertThat(computeActual("select * from system.jdbc.tables")); in TestGravitinoConnector.java and assertThat(computeActual("select * from system.jdbc.tables")); in TestGravitinoConnectorWithMetalakeCatalogName.java do not.

How should we improve?

Fix the assertions.

ishan-gupt commented 2 weeks ago

@justinmclean can you assign this to me

rohit-satya commented 2 weeks ago

@justinmclean Please review above PR