search

datastrato / gravitino

World's most powerful data catalog service with providing a high-performance, geo-distributed and federated metadata lake.
https://datastrato.ai/docs/
Apache License 2.0
347 stars 150 forks source link

[Improvement] Test arguments should be in the right order #3252

Closed justinmclean closed 1 week ago

justinmclean commented 2 weeks ago

What would you like to be improved?

A minor issue, but can cause confusion, test arguments should be in the right order.

Instances are as follows: x3 in CatalogsPageTest.java:

Assertions.assertEquals(driver.getTitle(), WEB_TITLE);

In TestHivePropertiesConverter.java:

Assertions.assertEquals(hiveProperties.get(HivePropertiesConstants.GRAVITINO_HIVE_FORMAT), "PARQUET");

How should we improve?

Swap order of arguments.

jerryshao commented 1 week ago

@kristopherkane can you please leave a comment here? So we can assign this issue to you.

kristopherkane commented 1 week ago

PR merged for 3252.