datastrato / gravitino

World's most powerful data catalog service with providing a high-performance, geo-distributed and federated metadata lake.
https://datastrato.ai/docs/
Apache License 2.0
347 stars 150 forks source link

[#3252] Improvement(IT): Test arguments should be in the right order #3255

Closed kristopherkane closed 1 week ago

kristopherkane commented 2 weeks ago

What changes were proposed in this pull request?

Equality assertions did not have correct expected and actual order.

Why are the changes needed?

Provides code clarity.

Fix: #3252

Does this PR introduce any user-facing change?

No

How was this patch tested?

Test only changes and ran associated tests.

xunliu commented 2 weeks ago

hi @kristopherkane Thank you for your contributions.

xunliu commented 2 weeks ago

hi @kristopherkane Please fix CI failed for Frontend Integration Test.

Build gravitino FAILURE reason:                                
    Execution failed for task ':spark-connector:spark-connector:spotlessJavaCheck':
        The following files had format violations:
            src/test/java/com/datastrato/gravitino/spark/connector/hive/TestHivePropertiesConverter.java
                @@ -37,7 +37,7 @@

FAILURE: Build failed with an exception.

                 ········hivePropertiesConverter.toGravitinoTableProperties(
* What went wrong:
Execution failed for task ':spark-connector:spark-connector:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/com/datastrato/gravitino/spark/connector/hive/TestHivePropertiesConverter.java
          @@ -37,7 +37,7 @@
           ········hivePropertiesConverter.toGravitinoTableProperties(
           ············ImmutableMap.of(TableCatalog.PROP_PROVIDER,·"PARQUET"));
           ····Assertions.assertEquals(
          -············"PARQUET",·hiveProperties.get(HivePropertiesConstants.GRAVITINO_HIVE_FORMAT));
          +········"PARQUET",·hiveProperties.get(HivePropertiesConstants.GRAVITINO_HIVE_FORMAT));
           ····hiveProperties·=
           ········hivePropertiesConverter.toGravitinoTableProperties(
           ············ImmutableMap.of(TableCatalog.PROP_PROVIDER,·"HIVE"));
  Run './gradlew :spark-connector:spark-connector:spotlessApply' to fix these violations.

I think you need execute ./gradlew :spark-connector:spark-connector:spotlessApply and commit.