search

datastrato / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://datastrato.ai/docs/
Apache License 2.0
616 stars 193 forks source link

[#3305] test(spark-connector): move spark connector integration test from integration-test module to spark-connector #3307

Closed FANNG1 closed 3 weeks ago

FANNG1 commented 1 month ago

What changes were proposed in this pull request?

move spark connector integration test from integration-test module to spark-connector

Why are the changes needed?

Fix: #3305

Does this PR introduce any user-facing change?

no

How was this patch tested?

moving test location

FANNG1 commented 4 weeks ago

This is blocked by #3441 , there are two ways to bypass:

  1. not support embedded mode for spark integration test
  2. replace java-client-runtime with java-client when testing, this is actually the same way why Integration tests works for spark connector IT for now.

I prefer option2 is no better solutions. @jerryshao , @qqqttt123 @yuqi1129 @diqiu50 @mchades , WDYT?

jerryshao commented 4 weeks ago

Use solution 2 for now.

FANNG1 commented 3 weeks ago

Use solution 2 for now.

ok

FANNG1 commented 3 weeks ago

@yuqi1129 @jerryshao could you help to review this PR, thanks

FANNG1 commented 3 weeks ago

@yuqi1129 do you have any other comment, @jerryshao do you want to review this PR?

FANNG1 commented 3 weeks ago

@jerryshao @yuqi1129 comments are addressed, please help to review again

yuqi1129 commented 3 weeks ago

I have no further comments.